Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntactic sugar for fn::open #14

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Add syntactic sugar for fn::open #14

merged 10 commits into from
Sep 27, 2023

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Sep 27, 2023 •
edited
Loading

Fixes #8

This sort of parallels what we did for adding syntactic sugar over invokes in pulumi-yaml https://github.com/pulumi/pulumi-yaml/pull/294/files#diff-9741bbf71a26e9f0f2d742b64509dd322d854b909f4c4c64e28075dc5d57f4e6R747 – might be easier than replacing fn::open altogether? Open to suggestions

aq17
aq17 commented Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
lblackstone
lblackstone reviewed Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
@aq17 @lblackstone
change regex to ^fn::open::[a-zA-Z-]+$
dd3ed12 
Co-authored-by: Levi Blackstone <levi@pulumi.com>
@aq17 aq17 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 27, 2023
pgavlin
pgavlin reviewed Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
pgavlin
pgavlin requested changes Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
ast/expr.go Outdated Show resolved Hide resolved
@aq17 aq17 force-pushed the aqiu/8 branch 2 times, most recently from 7d1ade9 to dd3ed12 Compare September 27, 2023 19:09
@aq17 @pgavlin
better provider name check/parse
a1b0903 
Co-authored-by: Pat Gavlin <pat@pulumi.com>
@aq17 aq17 requested a review from pgavlin September 27, 2023 19:23
@aq17 aq17 marked this pull request as ready for review September 27, 2023 19:23
pgavlin
pgavlin requested changes Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
pgavlin
pgavlin reviewed Sep 27, 2023
View reviewed changes
ast/expr.go Outdated Show resolved Hide resolved
pgavlin
pgavlin approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the example test; LGTM otherwise.

ast/environment_test.go Outdated Show resolved Hide resolved
@aq17 aq17 merged commit 5024d33 into main Sep 27, 2023
3 checks passed
@aq17 aq17 deleted the aqiu/8 branch September 27, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone left review comments

@pgavlin pgavlin pgavlin approved these changes

@cleverguy25 cleverguy25 Awaiting requested review from cleverguy25

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syntax: fn::open
3 participants
@aq17 @pgavlin @lblackstone